Skip to content

Conversation

@afma-odoo
Copy link
Contributor

No description provided.

@robodoo
Copy link
Collaborator

robodoo commented Jun 6, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested review from a team June 6, 2025 10:27
@afma-odoo afma-odoo requested review from auva-odoo and removed request for a team June 6, 2025 10:30
Copy link
Contributor

@LoredanaLrpz LoredanaLrpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @afma-odoo ; my review for the POS part is done, there are two things that change in saas-18.1 (Actions button and orders filters); tell me if you plan on coming back in saas-18.1; if not, I'll have it on my list of future tasks =)

@afma-odoo afma-odoo force-pushed the 18.0-localization-brazil-new-template-review-afma branch from 0bf0ef6 to 00db447 Compare June 10, 2025 11:29
@afma-odoo
Copy link
Contributor Author

@LoredanaLrpz Thank you for the review ☺️ Sure, I'll be glad to update these in saas-18.1!
Let me know if there's anything else :)

@afma-odoo afma-odoo requested a review from LoredanaLrpz June 10, 2025 11:45
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @afma-odoo for taking care of this so quickly and so well! I went through the whole page, even the parts you didn't change (sorry! I thought it'd be necessary for this big revamp, I hope you don't mind too much). I couldn't comment on the lines you didn't change of course so here are a few comments (sorry, this isn't very practical 🙈 )

  • line 453 (:guilabel:Payment Method: Brazil: how the invoice is planned to be paid) (I can't comment since you didn't change it): I would change the explanation to something a bit more in line with our usual style.
  • lines 488-489 (credit notes): I'd remove the seealso and instead add the ref in the text on line 482
  • lines 506-507: same as above but for debit notes
  • line 560: I would change the heading to: Invalidating invoice number range (or: Invoice number range invalidation? not sure)
  • Same section: I would merge the two notes
  • Line 616: we probably need to change the ref into a doc that refers to the AvaTax doc? (and maybe it might be worth checking the whole doc for other occurrences)
  • Also see my comment about the AvaTax integration in general

Let me know if you need anything!

@afma-odoo afma-odoo force-pushed the 18.0-localization-brazil-new-template-review-afma branch from 00db447 to 90ebc6c Compare July 2, 2025 09:29
@C3POdoo C3POdoo requested a review from a team July 2, 2025 09:47
@afma-odoo afma-odoo requested review from auva-odoo and removed request for a team July 2, 2025 10:08
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there @afma-odoo ! Thank you for patience and hard work on this! In addition to my comments, could you please also make sure to remove the capital in Email/Email address where relevant in the Avatax integration section? (I added a few comments but there are more).

@afma-odoo afma-odoo force-pushed the 18.0-localization-brazil-new-template-review-afma branch from 90ebc6c to 51d859a Compare July 9, 2025 06:44
@afma-odoo
Copy link
Contributor Author

Thank you @auva-odoo for your review 😊
Let me know if there's anything else ;) Thanks!

@afma-odoo afma-odoo requested a review from auva-odoo July 9, 2025 06:59
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes @afma-odoo and thank you for your patience with this doc page as a whole, I know it's been a bit of a journey 😅 But we are done! 🎉 (for now 🙈)

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants