-
Notifications
You must be signed in to change notification settings - Fork 10.8k
[IMP] accounting: l10n update brazilian page with new template #13619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LoredanaLrpz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @afma-odoo ; my review for the POS part is done, there are two things that change in saas-18.1 (Actions button and orders filters); tell me if you plan on coming back in saas-18.1; if not, I'll have it on my list of future tasks =)
0bf0ef6 to
00db447
Compare
|
@LoredanaLrpz Thank you for the review |
auva-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @afma-odoo for taking care of this so quickly and so well! I went through the whole page, even the parts you didn't change (sorry! I thought it'd be necessary for this big revamp, I hope you don't mind too much). I couldn't comment on the lines you didn't change of course so here are a few comments (sorry, this isn't very practical 🙈 )
- line 453 (:guilabel:
Payment Method: Brazil: how the invoice is planned to be paid) (I can't comment since you didn't change it): I would change the explanation to something a bit more in line with our usual style. - lines 488-489 (credit notes): I'd remove the seealso and instead add the ref in the text on line 482
- lines 506-507: same as above but for debit notes
- line 560: I would change the heading to: Invalidating invoice number range (or: Invoice number range invalidation? not sure)
- Same section: I would merge the two notes
- Line 616: we probably need to change the ref into a doc that refers to the AvaTax doc? (and maybe it might be worth checking the whole doc for other occurrences)
- Also see my comment about the AvaTax integration in general
Let me know if you need anything!
00db447 to
90ebc6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there @afma-odoo ! Thank you for patience and hard work on this! In addition to my comments, could you please also make sure to remove the capital in Email/Email address where relevant in the Avatax integration section? (I added a few comments but there are more).
90ebc6c to
51d859a
Compare
|
Thank you @auva-odoo for your review 😊 |
auva-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes @afma-odoo and thank you for your patience with this doc page as a whole, I know it's been a bit of a journey 😅 But we are done! 🎉 (for now 🙈)
@robodoo r+

No description provided.